Fix orbiter install looking at wrong path for orbiter_translations.version.version#121
Merged
fritz-astronomer merged 1 commit intomainfrom Dec 19, 2025
Merged
Fix orbiter install looking at wrong path for orbiter_translations.version.version#121fritz-astronomer merged 1 commit intomainfrom
orbiter install looking at wrong path for orbiter_translations.version.version#121fritz-astronomer merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the orbiter install command where it was looking at the wrong path when attempting to retrieve the version information from the orbiter_translations package. The fix adds a fallback mechanism to handle the case where the version is located at a nested path.
- Adds exception handling to catch
AttributeErrorwhen importing the version - Implements a fallback import path (
orbiter_translations.version.version) when the primary path fails
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 78.92% 82.67% +3.74%
==========================================
Files 35 51 +16
Lines 1362 1991 +629
==========================================
+ Hits 1075 1646 +571
- Misses 287 345 +58 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.