Modify Default Translation - Allow Running Filters "upfront" and in "parallel"#110
Merged
fritz-astronomer merged 7 commits intomainfrom Nov 21, 2025
Merged
Modify Default Translation - Allow Running Filters "upfront" and in "parallel"#110fritz-astronomer merged 7 commits intomainfrom
fritz-astronomer merged 7 commits intomainfrom
Conversation
5472c32 to
04484b1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for parallel and upfront translation modes in the Orbiter translation system. The changes introduce two new configuration options: parallel (enables multi-processing for filter operations) and upfront (runs all filtering before extraction steps).
- Adds
TranslationConfigwithparallelandupfrontboolean flags - Refactors the
translatefunction to support three execution modes: default sequential, upfront sequential, and upfront parallel - Updates test suite to validate all three translation modes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| orbiter/rules/rulesets.py | Defines TranslationConfig class with parallel and upfront fields to control translation execution modes |
| orbiter/default_translation.py | Refactors translation logic into helper functions and adds branching logic to support upfront and parallel execution modes |
| tests/orbiter/rules/rulesets_test.py | Adds fixture for test setup and three test functions to validate default, upfront, and parallel translation modes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 78.92% 82.65% +3.72%
==========================================
Files 35 51 +16
Lines 1362 1960 +598
==========================================
+ Hits 1075 1620 +545
- Misses 287 340 +53 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: fritz-astronomer <80706212+fritz-astronomer@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: fritz-astronomer <80706212+fritz-astronomer@users.noreply.github.com>
245ee2c to
fd23136
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be used like:
e.g.
https://github.com/astronomer/orbiter-translations/blob/autosys_p1.2/orbiter_translations/autosys/jil_base.py#L1238-L1245