Merged
Conversation
Contributor
fritz-astronomer
commented
Oct 31, 2025
- fix: add back *args for rules
- test/fix: path is now relative
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two issues: restores support for positional arguments in rules and updates a test assertion to use a relative path instead of an absolute path.
- Adds
*argssupport to theRule.__call__method and properly tracks visited keys for positional arguments - Updates integration test to expect relative path format (
workflow/demo.xml) instead of absolute path (/data/workflow/demo.xml)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| orbiter/rules/init.py | Adds *args parameter to Rule.__call__, implements tracking for positional arguments, and includes them in visited keys collection |
| tests/integration_test.py | Updates assertion to check for relative path format in translation output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 78.92% 82.32% +3.39%
==========================================
Files 35 51 +16
Lines 1362 1890 +528
==========================================
+ Hits 1075 1556 +481
- Misses 287 334 +47 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.