Merged
Conversation
…e an object say if it wants "_task" or not, rather than deps), add dereferenced_downstream - to figure out which operator belongs to which task_id to see if it's a task_group
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances TaskGroup downstream dependency handling by adding dereferencing capabilities and extracting common functionality for AST rendering.
- Adds
get_rendered_task_idmethod to distinguish between task and task group naming conventions - Introduces
dereference_downstreamfunctionality to resolve string references to actual task objects - Extracts shared downstream AST rendering logic to a common utility function
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/orbiter/objects/task_group_test.py | Adds test case verifying TaskGroup downstream dependency rendering |
| orbiter/objects/tasks_parent_shared_utils.py | Updates task dependency parent lookup to handle both string and object references |
| orbiter/objects/task_shared_utils.py | Extracts common downstream AST rendering logic and adds import statements |
| orbiter/objects/task_group.py | Refactors to use shared utilities and adds dereferenced downstream support |
| orbiter/objects/task.py | Refactors to use shared utilities and adds get_rendered_task_id method |
| orbiter/objects/dag.py | Adds dereference_downstream function and integrates it into AST generation |
| orbiter/ast_helper.py | Adds None check to render_ast function |
| orbiter/init.py | Version bump to 1.8.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 78.92% 81.91% +2.98%
==========================================
Files 35 50 +15
Lines 1362 1847 +485
==========================================
+ Hits 1075 1513 +438
- Misses 287 334 +47 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_rendered_task_id- to have an object say if it wants "_task" or not, rather than guessing at dependency timeCloses #69