fix: replace kin-openapi with libopenapi for OpenAPI 3.1 support#2032
Merged
jeremybeard merged 1 commit intomainfrom Mar 6, 2026
Merged
fix: replace kin-openapi with libopenapi for OpenAPI 3.1 support#2032jeremybeard merged 1 commit intomainfrom
jeremybeard merged 1 commit intomainfrom
Conversation
Airflow 3.1+ uses OpenAPI 3.1's numeric exclusiveMinimum which kin-openapi v0.131.0 cannot parse, causing silent failures and "no endpoints found" errors. Replace with pb33f/libopenapi v0.34.0 which fully supports OpenAPI 3.0, 3.1, and 3.2. Introduces self-contained types in pkg/openapi/types.go so the library dependency is isolated to the parsing layer, making tests simpler and future library swaps trivial. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Pull Request Test Coverage Report for Build 39cf7016-9a3f-4837-b18b-8531b648428fDetails
💛 - Coveralls |
schnie
reviewed
Mar 6, 2026
| github.com/fsnotify/fsevents v0.2.0 // indirect | ||
| github.com/fxamacker/cbor/v2 v2.7.0 // indirect | ||
| github.com/fzipp/gocyclo v0.6.0 // indirect | ||
| github.com/getkin/kin-openapi v0.131.0 // indirect |
Member
There was a problem hiding this comment.
Why does kin still get pulled in?
Contributor
Author
There was a problem hiding this comment.
"indirect" means it's a transitive dependency of something else. It was already there before I added the feature, this is why I used it in the first place, turns out it wasn't the best choice!
schnie
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kin-openapiwithpb33f/libopenapiv0.34.0 to fix OpenAPI 3.1 spec parsing for Airflow 3.1+exclusiveMinimum(OpenAPI 3.1), which kin-openapi v0.131.0 silently fails to parse, resulting in "no endpoints found"pkg/openapi/types.goso the library dependency is isolated to the parsing layer, making tests simpler and future library swaps trivialTest plan
go build ./...compiles cleanlygo test ./pkg/openapi/... ./cmd/api/...all tests passastro api airflow ls --airflow-version 3.1.7lists endpoints successfullyastro api airflow ls --airflow-version 3.0.3still works for 3.0.xastro api airflow ls --airflow-version 2.10.0still works for 2.xastro api airflow describe get_dags --airflow-version 3.1.7schema details display correctlyastro api airflow lsworks with live local Airflow instance (auto-detect version)🤖 Generated with Claude Code