Skip to content

fix(standalone): pass --python to uv pip install to target project venv#2029

Merged
jeremybeard merged 1 commit intomainfrom
fix/standalone-strip-virtual-env
Mar 6, 2026
Merged

fix(standalone): pass --python to uv pip install to target project venv#2029
jeremybeard merged 1 commit intomainfrom
fix/standalone-strip-virtual-env

Conversation

@jeremybeard
Copy link
Contributor

@jeremybeard jeremybeard commented Mar 5, 2026

Summary

  • When the CLI is launched from inside an activated venv (e.g. via uv run), the inherited VIRTUAL_ENV env var causes uv pip install to target the parent venv instead of the project's .venv/, leaving .venv/bin/airflow missing
  • Passes --python .venv/bin/python explicitly to both uv pip install commands so they always install into the project venv regardless of the parent environment

Test plan

  • Full ./airflow/ test suite passes
  • Integration test: VIRTUAL_ENV=/fake astro dev start --standalone succeeds, .venv/bin/airflow exists in project venv

🤖 Generated with Claude Code

@jeremybeard jeremybeard marked this pull request as ready for review March 5, 2026 20:13
@jeremybeard jeremybeard requested a review from a team as a code owner March 5, 2026 20:13
@coveralls-official
Copy link

coveralls-official bot commented Mar 5, 2026

Pull Request Test Coverage Report for Build 1f89c2ab-978a-4c1c-a672-d0961ec29850

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 249 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.08%) to 35.945%

Changes Missing Coverage Covered Lines Changed/Added Lines %
airflow/standalone.go 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
cmd/root.go 1 97.53%
pkg/openapi/schema.go 1 96.3%
pkg/openapi/endpoints.go 3 96.0%
pkg/openapi/cache.go 18 87.74%
cmd/api/describe.go 19 93.18%
airflow/proxy/daemon.go 30 31.09%
airflow/proxy/routes.go 43 68.15%
airflow/standalone.go 134 77.14%
Totals Coverage Status
Change from base Build be8b1c54-7a3d-4f57-9917-b5797bc53d98: 0.08%
Covered Lines: 24318
Relevant Lines: 67653

💛 - Coveralls

When the CLI is launched from inside an activated venv (e.g. via `uv run`),
the inherited VIRTUAL_ENV env var causes `uv pip install` to target the
parent venv instead of the project's .venv, leaving .venv/bin/airflow missing.

Pass --python .venv/bin/python explicitly to uv pip install commands so they
always install into the project venv regardless of the parent environment.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jeremybeard jeremybeard force-pushed the fix/standalone-strip-virtual-env branch from f2d1f16 to bfb2f34 Compare March 6, 2026 14:40
@jeremybeard jeremybeard changed the title fix(standalone): strip VIRTUAL_ENV from env before uv commands fix(standalone): pass --python to uv pip install to target project venv Mar 6, 2026
@jeremybeard jeremybeard merged commit 14ee993 into main Mar 6, 2026
5 of 6 checks passed
@jeremybeard jeremybeard deleted the fix/standalone-strip-virtual-env branch March 6, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants