fix: mock registry API in tests and add HTTP client timeouts#2025
Merged
fix: mock registry API in tests and add HTTP client timeouts#2025
Conversation
Registry tests were making real HTTP calls to api.astronomer.io with no timeout, causing CI failures when the API is slow or unresponsive. This replaces real API calls with httptest mock servers and adds a 30s timeout to HTTP clients in httputil. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jeremybeard
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd/registry) were making real HTTP calls toapi.astronomer.iowith no timeout on the HTTP client, causing CI to hang for 120+ seconds and fail when the API is slow or unresponsivehttptestmock servers so tests are fast, deterministic, and have no external dependencyRequestAndGetJSONBodyandDownloadResponseToFileto prevent the CLI itself from hanging indefinitelyTest plan
go test -count=1 ./cmd/registry/...passes in <1s (was 120s+ timeout)go test ./...passes🤖 Generated with Claude Code