Clean up context, agent and ci_system event properties#2021
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Agents: Cursor (CURSOR_AGENT), Snowflake Cortex, Gemini CLI, OpenCode, Codex CI: Jenkins (HUDSON_URL), Azure DevOps, Bitbucket Pipelines, AWS CodeBuild, TeamCity, Buildkite, Codefresh, Travis CI Aligns with astronomer/agents#141. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Removes duplicated agent/CI env var lists in tests by reading directly from agentEnvVars and ciEnvVars via a helper function. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
a17cd42 to
8cdc254
Compare
jlaneve
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DetectContext()into three independent functions:DetectAgent(),DetectCISystem(), andIsInteractive()— the old function mixed agent, CI, and interactivity into a single field, making it impossible to see e.g. Claude Code running inside GitHub Actionscontextis now"interactive"/"non-interactive", with separateagentandci_systemproperties added only when detectedisTestRun()detection (checks for.testbinary suffix) to prevent Go test binaries from sending real events to prodTest plan
go build ./...go test ./pkg/telemetry/... -v— all tests pass including newTestDetectAgent,TestDetectCISystem,TestIsInteractive,TestIsTestRungolangci-lint run ./pkg/telemetry/...— no issuesASTRO_TELEMETRY_DEBUG=1 GITHUB_ACTIONS=true astro version— verifycontext,agent, andci_systemappear independently