chore(sequencer): add instrumentation#1761
Merged
ethanoroshiba merged 9 commits intomainfrom Dec 19, 2024
Merged
Conversation
Fraser999
suggested changes
Dec 2, 2024
Contributor
Fraser999
left a comment
There was a problem hiding this comment.
Blocking this for now (as much a reminder to myself as anything else).
Discussed offline with @ethanoroshiba that this will be revisited to ensure we're only using error-level instrumentation where it's warranted (i.e. where it indicates a serious problem or bug in the logic) and not for non-critical cases (e.g. handling a malformed client request).
Fraser999
reviewed
Dec 16, 2024
Fraser999
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added instrumentation to most async functions which did not have it.
Background
Adding instrumentation to all async calls will aid in tracing since spans will be emitted even if no events happen under them.
Changes
errargument to theinstrumentmacro where applicable.instrumentmacro where applicable.Testing
Passing all tests.
Changelogs
No updates required
Related Issues
closes #1321