Conversation
cbb7346 to
d5ede81
Compare
d5ede81 to
2068caf
Compare
joroshiba
reviewed
Oct 22, 2024
Member
joroshiba
left a comment
There was a problem hiding this comment.
Do we have any tests over this? I would ideally have a snapshot test that validates that json memos don't change
joroshiba
approved these changes
Oct 23, 2024
Member
joroshiba
left a comment
There was a problem hiding this comment.
Approved based on my other passing test built on top of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the full hex encoded sender of the smart contract event as the rollup return address in the ics20 withdrawal event memo.
Background
Before this patch, the
astria.protocol.memos::v1::Ics20WithdrawalFromRollupmemo used the abbreviated form of the ethers contract event sender, making it impossible to return funds if necessary. Specifically, the field was set asrollupReturnAddress":"0xc59a…2d94"After this patch, the full address is used, making it possible to identify the sender.
Changes
AbiEncode::encode_hex()instead ofH160::to_string()Breaking Changelist
Related Issues
Original issue where this was first encountered but not fixed: #1427