chore(sequencer): separate test utils from shared benchmark and test utils#1613
Merged
ethanoroshiba merged 4 commits intomainfrom Oct 29, 2024
Merged
chore(sequencer): separate test utils from shared benchmark and test utils#1613ethanoroshiba merged 4 commits intomainfrom
ethanoroshiba merged 4 commits intomainfrom
Conversation
noot
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separated utils only used by tests from utils used by both benchmarks and tests.
Background
This is to get rid of many strings of nested
expects andallows mentioned in #1585Changes
astria-sequencer::test_utils.rsintotest_utils.rsandbenchmark_and_test_utils.rs.astria-sequencer::app::test_utils.rsintoapp::test_utils.rsandapp::benchmark_and_test_utils.rs.Testing
All tests working
Related Issues
closes #1585