-
Notifications
You must be signed in to change notification settings - Fork 96
Make CheckTx checks stricter #1958
Copy link
Copy link
Labels
bugSomething isn't workingSomething isn't workingignore-staleOverride for issues or PRs which should not be removed if stale.Override for issues or PRs which should not be removed if stale.mempoolsequencerpertaining to the astria-sequencer cratepertaining to the astria-sequencer cratestale
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingignore-staleOverride for issues or PRs which should not be removed if stale.Override for issues or PRs which should not be removed if stale.mempoolsequencerpertaining to the astria-sequencer cratepertaining to the astria-sequencer cratestale
We currently are too permissive in our CheckTx flow, allowing txs into the CometBFT and appside mempools which will subsequently fail execution via stateful checks in the
check_and_executeflow.This is problematic as such txs are not recorded in the sequencer block nor in the CometBFT txs. This means they remain present in the mempools of all but the validator proposing the block for that round.
A design to improve this situation has been created here.
This ticket will implement the first part of the suggested changes, i.e. stricter checks during CheckTx.