Skip to content

Add black box tests to composer to cover deleted internal tests #1652

@itamarreif

Description

@itamarreif

PR #1643 removes fragile tests that were internal to the composer crate as they were a maintenance burden.

The tests that are removed:

  1. full_bundle - This is covered by the unit tests in the bundle_factory module internal to the composer. Probably doesn't require adding a new black box test.
  2. bundle_triggered_by_block_timer - This test assumes quite a bit of knowledge about the internal functions of the composer (specifically that if the bundle isn't filled then it will be submitted after the block timer).
  3. two_seq_actions_single_bundle - A test similar to the existing single_rollup_tx_payload_integrity that has two transactions should be added to cover this.
  4. chain_id_mismatch_returns_error - Likely requires bubbling errors up and out from the composer service.

┆Issue Number: ENG-914

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions