Skip to content

sequencer/mempool: CheckTX fails all rechecks #1481

@lobstergrindset

Description

@lobstergrindset

During the mempool rewrite CheckTX's functionality was accidentally changed to fail all CheckTxKind::Recheck calls. Previously attempting to re-insert a transaction into the mempool would not cause an error.

This is a UX regression as CometBFT is used to display to users the possible statuses of their transactions. We should allow the CheckTxKind::Recheck calls to succeed until we have better ways to report to users the status of their transactions. Nice to have also is basic unit testing for CheckTX.

┆Issue Number: ENG-811

Metadata

Metadata

Labels

mempoolobservabilityobservability, tracing, metricssequencerpertaining to the astria-sequencer crate

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions