## Summary Deduplicated and added metrics to `get_pending_nonce()`, fixed too many arguments in `process_batch()`. ## Background Following #1215, `get_pending_nonce()` was present in both the bridge-withdrawer and submitter, in which the submitter's `get_pending_nonce()` also did not implement metrics. The submitter's `process_batch()` function also had a Clippy exception for too many arguments. ## Changes - Deleted `bridge_withdrawer/startup.rs: get_pending_nonce()` and its helper function `make_sequencer_grpc_retry_config`. - Instead imported `submitter/mod.rs: get_pending_nonce()` and formatted accordingly. - Added optional metrics argument to submitter `get_pending_nonce()` to allow for it to be used in the bridge-withdrawer startup. - Added conditional metrics to `get_pending_nonce()`, as well as mutators within `Metrics`. - Moved `process_batch()` inside `Submitter` to allow for sharing of members between the two, cutting down arguments and removing Clippy exception. ## Testing Passes blackbox tests. ## Metrics - Added `nonce_fetch_count`. - Added `nonce_fetch_failure_count`. - Added `nonce_fetch_latency`. ## Related Issues Closes #1272 Closes #1273 Closes #1274 --------- Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>

Clean up too many arguments in PR #1215 #1273

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions