Skip to content

Sync build backend#7961

Merged
konstin merged 1 commit into
mainfrom
konsti/build-backend-sync
Oct 7, 2024
Merged

Sync build backend#7961
konstin merged 1 commit into
mainfrom
konsti/build-backend-sync

Conversation

@konstin

@konstin konstin commented Oct 7, 2024

Copy link
Copy Markdown
Member

Following the discussion at #7781 (comment), it makes more sense to keep the build backend sync.

@konstin konstin added the preview Experimental behavior label Oct 7, 2024
@konstin konstin requested a review from BurntSushi October 7, 2024 08:38
Base automatically changed from konsti/build-backend to main October 7, 2024 08:38
Following the discussion at #7781 (comment), it makes more sense to keep the build backend sync.
@konstin konstin force-pushed the konsti/build-backend-sync branch from 5055a63 to 315b884 Compare October 7, 2024 08:41
@konstin konstin merged commit 5d789c6 into main Oct 7, 2024
@konstin konstin deleted the konsti/build-backend-sync branch October 7, 2024 08:51
@konstin konstin changed the title Implement build backend metadata Sync build backend Oct 7, 2024

@BurntSushi BurntSushi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

/// Create a directory.
fn write_directory(&mut self, directory: &str) -> Result<(), Error>;

#[allow(clippy::unused_async)] // https://github.com/rust-lang/rust-clippy/issues/11660

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, will do in the next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Experimental behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants