chore: Remove dep on derivative#7133
Merged
charliermarsh merged 2 commits intoastral-sh:mainfrom Sep 6, 2024
Merged
Conversation
This is part of astral-sh#5711
zanieb
approved these changes
Sep 6, 2024
09b53f6 to
a30267e
Compare
BurntSushi
approved these changes
Sep 6, 2024
Member
BurntSushi
left a comment
There was a problem hiding this comment.
Makes sense to me! Thank you!
Contributor
Author
|
Was the windows test suite broken by one of the "temp dir in dev dir" PRs we landed recently? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is part of #5711)
Summary
@BurntSushi and I spotted that the
derivativecrate is only used for one enum in the entire codebase — however, it's a proc macro, and we pay for the cost of (re)compiling it in many different contexts.This replaces it with a private
Innercore which uses the regular std derive macros — inlining and optimizations should make this equivalent to the other implementation, and not too hard to maintain hopefully (versus a manual impl ofPartialEqandHashwhich have to be kept in sync.)Test Plan
Trust CI?