chore: run cargo dev generate-all on CI and locally#6899
Merged
charliermarsh merged 3 commits intoastral-sh:mainfrom Aug 31, 2024
Merged
chore: run cargo dev generate-all on CI and locally#6899charliermarsh merged 3 commits intoastral-sh:mainfrom
cargo dev generate-all on CI and locally#6899charliermarsh merged 3 commits intoastral-sh:mainfrom
Conversation
910d10c to
45a6554
Compare
45a6554 to
db44be8
Compare
charliermarsh
approved these changes
Aug 31, 2024
Member
charliermarsh
left a comment
There was a problem hiding this comment.
Thanks. I also noticed this recently. I think we have some actual Rust tests that run check for a few of the outputs but not all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Noticed that running
cargo dev generate-allonmainproduced changes and saw that that the command is not run on the CI nor as a pre-commit hook.Not sure if having the command running as a pre-commit hook is something we want, so I can remove it if you prefer. I find that nice to have as it's probably easy to forget to run it, especially for new contributors (and it will only run if there are changes in
uv_clioruv_settingscrates).Test Plan
cargo dev generate-all --mode checkon the CI, which produced this failing jobcargo dev generate-alllocally and committed the changes, which produced this succeeding job