Add source distribution support to uv-build crate#6896
Merged
charliermarsh merged 1 commit intomainfrom Sep 2, 2024
Merged
Conversation
charliermarsh
commented
Aug 31, 2024
| pub async fn build_wheel(&self, wheel_dir: &Path) -> Result<String, Error> { | ||
| // The build scripts run with the extracted root as cwd, so they need the absolute path. | ||
| let wheel_dir = fs::canonicalize(wheel_dir)?; | ||
| let wheel_dir = std::path::absolute(wheel_dir)?; |
Member
Author
There was a problem hiding this comment.
I also changed this from canonicalize to absolute, since the error isn't very good if the directory doesn't exist.
9fb3db7 to
f5d2f7c
Compare
konstin
approved these changes
Sep 2, 2024
f5d2f7c to
dd6fb14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Just exposes the correct PEP 517 hooks.