Conversation
zanieb
reviewed
Aug 27, 2024
zanieb
reviewed
Aug 27, 2024
When not using a python base image and using alpine, you need to install python by yourself. You should also pin the python version when doing so; currently, i see only python 3.12 in the alpine repository.
d000ffe to
0c491e7
Compare
zanieb
reviewed
Aug 27, 2024
docs/guides/integration/docker.md
Outdated
| in your repository to prevent it from being included in image builds. The project virtual | ||
| environment is dependent on your local platform and should be created from scratch in the image. | ||
|
|
||
| !!! note |
Member
There was a problem hiding this comment.
Sorry I should have noticed this in the first run. This is kind of a weird spot? Can we put this in a new section at the bottom or something? It feels quite prominent here and we're not talking about installing Python at all.
Member
|
It looks like my comments were marked as addressed but there's no change? |
Member
Author
|
I had accepted both of them, not sure what the merge had done here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When not using a python base image and using alpine, you need to install python by yourself. You should also pin the python version when doing so; currently, i see only python 3.12 in the alpine repository.