Skip to content

Force color for build error messages#3032

Merged
konstin merged 1 commit intomainfrom
konsti/force-color-for-builds
Apr 15, 2024
Merged

Force color for build error messages#3032
konstin merged 1 commit intomainfrom
konsti/force-color-for-builds

Conversation

@konstin
Copy link
Member

@konstin konstin commented Apr 15, 2024

Since we're using anstream's strip stream, we can force color output from child processes and strip them when we redirect to a file

Before:

image

After:

image

Redirecting to a file correctly strips color codes.

@konstin konstin added enhancement New feature or improvement to existing functionality error messages Messaging when something goes wrong and removed enhancement New feature or improvement to existing functionality labels Apr 15, 2024
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

error messages Messaging when something goes wrong

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants