uv-cache: bump built-wheels cache version#2715
Merged
Conversation
It turns out that #2712 did _not_ fix #2711. After I put up #2712, I started trying to track down the specific change that caused the failure. I had assumed at first that it was related to one of our `rkyv` types, but it actually ended up being one of our msgpack caches. I think the failure mode is still fundamentally the same idea: the cached data changed in a way that is still valid msgpack, but got interpreted differently after deserializing. The specific change that caused this was the [removal of a field] from our metadata type. Ideally we would just undo the change and add the field back. But that change has already been shipped out to users. So I believe the only plausible choice at this point is to bump the `built-wheels` cache. This will unfortunately mean that `uv` will need to re-build wheels. Fixes #2711 [removal of a field]: 365c292#diff-e42586829f9c2cdbb909bedc5cf95691cc415247f2cbc2ebeb80d887020457bbL29
zanieb
approved these changes
Mar 28, 2024
Member
Author
|
Here is my test protocol. First, the failure: And now a demonstration that this PR doesn't have the issue: |
charliermarsh
approved these changes
Mar 28, 2024
Member
|
You should also be able to un-bump the simple cache version. |
Member
|
But... I don't feel strongly. Let's just leave it bumped actually. |
Member
Author
|
Yeah I thought about that, but didn't want to get too cute since that bump already landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that #2712 did not fix #2711. After I put up #2712, I
started trying to track down the specific change that caused the
failure. I had assumed at first that it was related to one of our
rkyvtypes, but it actually ended up being one of our msgpack caches. I think
the failure mode is still fundamentally the same idea: the cached data
changed in a way that is still valid msgpack, but got interpreted
differently after deserializing.
The specific change that caused this was the removal of a field from our
metadata type.
Ideally we would just undo the change and add the field back. But that
change has already been shipped out to users. So I believe the only
plausible choice at this point is to bump the
built-wheelscache. Thiswill unfortunately mean that
uvwill need to re-build wheels.Fixes #2711