Skip to content

Recursively allow URL requirements for local dependencies#2702

Merged
charliermarsh merged 1 commit intomainfrom
charlie/recur
Mar 28, 2024
Merged

Recursively allow URL requirements for local dependencies#2702
charliermarsh merged 1 commit intomainfrom
charlie/recur

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh commented Mar 28, 2024 •
edited
Loading

Summary

This is a trimmed-down version of #2684 that only applies to local source trees for now, which enables workspace-like workflows (whereby local packages can depend on other local packages at arbitrary depth).

Closes #2699.

Test Plan

Added new tests.

Also cloned this MRE that was shared with me (https://github.com/timothyjlaurent/uv-poetry-monorepo-mre), and verified that it was installed without error:

❯ cargo run pip install ./uv-poetry-monorepo-mre/app --no-cache
    Finished dev [unoptimized + debuginfo] target(s) in 0.15s
     Running `target/debug/uv pip install ./uv-poetry-monorepo-mre/app --no-cache`
Resolved 4 packages in 1.28s
   Built app @ file:///Users/crmarsh/workspace/uv/uv-poetry-monorepo-mre/app
   Built lib1 @ file:///Users/crmarsh/workspace/uv/uv-poetry-monorepo-mre/lib1
   Built lib2 @ file:///Users/crmarsh/workspace/uv/uv-poetry-monorepo-mre/lib2                                        Downloaded 4 packages in 457ms
Installed 4 packages in 2ms
 + app==0.1.0 (from file:///Users/crmarsh/workspace/uv/uv-poetry-monorepo-mre/app)
 + lib1==0.1.0 (from file:///Users/crmarsh/workspace/uv/uv-poetry-monorepo-mre/lib1)
 + lib2==0.1.0 (from file:///Users/crmarsh/workspace/uv/uv-poetry-monorepo-mre/lib2)
 + ruff==0.3.4

@charliermarsh charliermarsh marked this pull request as ready for review March 28, 2024 02:03
@charliermarsh charliermarsh requested a review from zanieb March 28, 2024 02:03
@charliermarsh charliermarsh added the enhancement New feature or improvement to existing functionality label Mar 28, 2024
@charliermarsh charliermarsh requested a review from konstin March 28, 2024 13:40
@charliermarsh charliermarsh mentioned this pull request Mar 28, 2024
Merged
@charliermarsh charliermarsh enabled auto-merge (squash) March 28, 2024 22:45
@charliermarsh charliermarsh merged commit 1f31350 into main Mar 28, 2024
@charliermarsh charliermarsh deleted the charlie/recur branch March 28, 2024 22:53
@BrewTestBot BrewTestBot mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanieb zanieb zanieb approved these changes

@konstin konstin Awaiting requested review from konstin

Assignees

No one assigned

Labels

enhancement New feature or improvement to existing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow direct URLs to be used recursively for local projects

2 participants

@charliermarsh @zanieb