Avoid using setuptools shim of distutils#2305
Merged
charliermarsh merged 1 commit intomainfrom Mar 8, 2024
Merged
Conversation
Member
Author
|
@gaborbernat - do you know if it's necessary for virtualenv to use the patched version of |
|
Nice! |
Contributor
|
I believe this aligns with how packages behave. pip uses setuptools distutils historically for installing packages. So without that shim you might end up with bug reports of installations ending up in expected locations when the OS patched distutils and setuptools distutils information differs (primarily in debian). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It turns out that setuptools includes a shim to patch distutils. I'll admit that I don't fully understand why or how it's different, but this is the trick
pipuses to ensure that it gets the "original" distutils.We actually use distutils in two places: once for the system Python scheme, and once for virtual environments. In virtualenv, they do use the patched distutils, so this could deviate in ways I don't understand.
Closes #2302.