Skip to content

Use Namespace runners for Windows Clippy and tests#19751

Merged
zanieb merged 1 commit into
astral-sh:mainfrom
zaniebot:zb/use-namespace-windows-clippy-tests
Jun 9, 2026
Merged

Use Namespace runners for Windows Clippy and tests#19751
zanieb merged 1 commit into
astral-sh:mainfrom
zaniebot:zb/use-namespace-windows-clippy-tests

Conversation

@zaniebot

@zaniebot zaniebot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Moves to equivalent Namspace runners for Windows instead of GitHub, which show the greatest performance improvement (picked out from #19604). These runners do not support persistent cache volumes in namespace and, unlike Depot, they do not hijack the action/cache API so we're still just using GitHub's caching model here alleviating any concerns about cache poisoning.

@zaniebot

zaniebot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author
Job main Namespace Improvement
check-lint / clippy on windows 3:00 1:29 50%
test / cargo test on windows 1–3 of 3 7:31–9:02 4:00–4:56 39–52%
all required jobs passed 10:17 5:29 47%

Values are medians. The required-check comparison uses eight comparable main runs and two Namespace runs; initial queue time is excluded.

@zanieb zanieb marked this pull request as ready for review June 9, 2026 14:14
@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Jun 9, 2026

@zsol zsol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow.

@zanieb zanieb merged commit 7a7f90c into astral-sh:main Jun 9, 2026
105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants