Skip to content

Don't use --update with apt in CI#19633

Merged
woodruffw merged 2 commits into
mainfrom
ww/fix-apt
Jun 1, 2026
Merged

Don't use --update with apt in CI#19633
woodruffw merged 2 commits into
mainfrom
ww/fix-apt

Conversation

@woodruffw

@woodruffw woodruffw commented Jun 1, 2026

Copy link
Copy Markdown
Member

Summary

apt install --update ... is roughly equivalent to running apt update && apt install ... on newer apt versions. I think this is almost never what we want, at least in CI:

  1. It's slow, since updating forces apt to refresh all index listings (including third party listings that happen to be enabled on the runner, like the Google Chrome listing).
  2. It's a source of unreliability/flakes, since listings frequently either 404 or are not updated atomically, meaning apt fails with consistency errors. Example: https://github.com/astral-sh/uv/actions/runs/26763578883/job/78883783836?pr=18927

Note: I haven't changed this in any Dockerfiles, since I don't think --update is as much of a reliability risk there.

NB: There's one place where I think we want it, i.e. when we do dpkg --add-architecture since dpkg won't update the lists for us.

Test Plan

NFC. CI only.

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw self-assigned this Jun 1, 2026
@woodruffw woodruffw added the ci-flake Related to internal CI flakes label Jun 1, 2026
@woodruffw woodruffw changed the title Don't use --update with apt Don't use --update with apt in CI Jun 1, 2026
Comment thread .github/workflows/test-integration.yml Outdated
Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw marked this pull request as ready for review June 1, 2026 16:00
@woodruffw woodruffw added the internal A refactor or improvement that is not user-facing label Jun 1, 2026
@woodruffw woodruffw requested review from EliteTK and zanieb June 1, 2026 16:02
@woodruffw woodruffw merged commit ebd9dee into main Jun 1, 2026
53 checks passed
@woodruffw woodruffw deleted the ww/fix-apt branch June 1, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-flake Related to internal CI flakes internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants