Skip to content

Fix JUnit upload on Windows runners#19370

Merged
woodruffw merged 1 commit into
mainfrom
ww/fix-junit
May 11, 2026
Merged

Fix JUnit upload on Windows runners#19370
woodruffw merged 1 commit into
mainfrom
ww/fix-junit

Conversation

@woodruffw

Copy link
Copy Markdown
Member

Summary

This was an oversight from #19330. We're running our tests on Windows in a Dev Drive, so we need to fixup the path rather than assuming that CWD has a target dir.

Test Plan

NFC.

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw requested a review from zanieb May 11, 2026 20:24
@woodruffw woodruffw self-assigned this May 11, 2026
@woodruffw woodruffw added the internal A refactor or improvement that is not user-facing label May 11, 2026
@woodruffw

woodruffw commented May 11, 2026

Copy link
Copy Markdown
Member Author

(Will confirm this by looking at CI logs like a caveman.)

Edit: Working as expected.

@woodruffw woodruffw requested a review from charliermarsh May 11, 2026 20:35
@woodruffw woodruffw merged commit 374fcaa into main May 11, 2026
52 checks passed
@woodruffw woodruffw deleted the ww/fix-junit branch May 11, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants