Ensure publish to crates.io is idempotent#19361
Merged
Merged
Conversation
b5d33dd to
6d8c0f3
Compare
zanieb
commented
May 11, 2026
| @@ -0,0 +1,70 @@ | |||
| import importlib.util | |||
Member
Author
There was a problem hiding this comment.
Oh, I think I'll remove this file. I don't want tests Codex is just insistent
Co-authored-by: Codex <noreply@openai.com>
6d8c0f3 to
a813d96
Compare
zsol
approved these changes
May 11, 2026
| import sys | ||
| import unittest | ||
|
|
||
| REPO_ROOT = pathlib.Path(__file__).resolve().parent.parent.parent |
Member
There was a problem hiding this comment.
I hate these, would much prefer git rev-parse --show-toplevel
| CRATES_IO_API = "https://crates.io/api/v1" | ||
| USER_AGENT = "uv-crates-io-publish (github.com/astral-sh/uv)" | ||
|
|
||
| REPO_ROOT = pathlib.Path(__file__).resolve().parent.parent |
Member
There was a problem hiding this comment.
same thing here, git parse-rev --show-repo-root
Member
Author
There was a problem hiding this comment.
Hm this is a standard pattern in our Python scripts today. I'm not sure it should require git.
Member
Author
There was a problem hiding this comment.
Let's revisit it separately, if that's okay?
| @@ -0,0 +1,70 @@ | |||
| import importlib.util | |||
Member
Author
There was a problem hiding this comment.
Naw I'm deleting it it's silly. I didn't mean to commit it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.