Merged
Conversation
9fc6327 to
bef0153
Compare
bef0153 to
f47fbdd
Compare
konstin
approved these changes
Mar 25, 2026
f47fbdd to
2a9fbc3
Compare
2a9fbc3 to
eab0b03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves from a crates.io API key to trusted publishing.
Setup of trusted publishing is automated via a script which creates the trust relationship and disables publish by API key. The main breakage here is that now, when we add a new crate, a release will fail. The script is invoked during
release.shto catch this case and supports creating a stub crate so the release can subsequently succeed — but this will require the release author to have a local crates.io API key with permissions to create projects and configure publishing. I tested this script a few times end-to-end, but would not be surprised if it bites us in the future.