Conditionalize two new tests on the test-pypi feature#18369
Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom Mar 8, 2026
Merged
Conditionalize two new tests on the test-pypi feature#18369charliermarsh merged 1 commit intoastral-sh:mainfrom
charliermarsh merged 1 commit intoastral-sh:mainfrom
Conversation
Both `build_backend::tool_uv_build_backend_without_build_backend` and `build_backend::tool_uv_build_backend_wrong_build_backend` fail in offline environments because they try to download a build backend from PyPI.
Contributor
Author
Don’t worry about it! Sending a quick PR now and then is still much nicer than keeping a list of tests to skip downstream. Thanks for the swift review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both
build_backend::tool_uv_build_backend_without_build_backendandbuild_backend::tool_uv_build_backend_wrong_build_backendfail in offline environments because they try to download a build backend from PyPI.This PR conditionalizes both tests on the existing
test-pypifeature.Test Plan
Applied as a downstream patch to Fedora’s
uvpackage.