Improve unsat diagnostics by attributing transitive pins to constraints files#17993
Open
terror wants to merge 1 commit intoastral-sh:mainfrom
Open
Improve unsat diagnostics by attributing transitive pins to constraints files#17993terror wants to merge 1 commit intoastral-sh:mainfrom
terror wants to merge 1 commit intoastral-sh:mainfrom
Conversation
Member
|
Cool! I just delegated this to an agent briefly, but like... what do you think about transforming the tree instead? ac6739a I think that is a more helpful error? though it's more likely to break in some weird way? |
Member
|
(oops) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #17960
This diff improves resolver error diagnostics when a transitive dependency conflict is caused by a constraints file (e.g., via
--constraint/UV_CONSTRAINTS). Previously, the unsatisfiable trace could make it look like an intermediate package was directly pinning a dependency, which is technically true in the derived graph but misleading about where that pin originated.