Add preview option to respect umask when creating lock files#17961
Draft
Add preview option to respect umask when creating lock files#17961
Conversation
64bb690 to
ad4fc92
Compare
ad4fc92 to
f1f9919
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16769
Closes #17646
Add the
respect-umaskpreview feature which allows a breaking cache change which makes uv respect the umask when creating cache lock files.The PR also changes this globally everywhere else, which is also a breaking change (To Do: Investigate if we also have a policy here, and also consider making these also preview configurable).
Happy to hear any comments, I'm still undecided on the approach or the naming.
Test Plan
To Do