docs(timeout): clarify timeout format in error messages#17668
Open
LouisLau-art wants to merge 1 commit intoastral-sh:mainfrom
Open
docs(timeout): clarify timeout format in error messages#17668LouisLau-art wants to merge 1 commit intoastral-sh:mainfrom
LouisLau-art wants to merge 1 commit intoastral-sh:mainfrom
Conversation
When a network timeout occurs, explicitly mention that UV_HTTP_TIMEOUT should be an integer in seconds. Additionally, provide a helpful suggestion when parsing any environment variable containing 'TIMEOUT' fails due to an 's' suffix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16940.
Currently, if a network timeout occurs, uv displays the timeout as
30s. This leads users to try settingUV_HTTP_TIMEOUT=60s, which fails because it expects a plain integer.This PR:
expected an integer (in seconds)) when parsing any variable containingTIMEOUTfails and the value ends withs.Verified with:
UV_HTTP_TIMEOUT=60s cargo run venv # error: Failed to parse environment variable `UV_HTTP_TIMEOUT` with invalid value `60s`: invalid digit found in string; expected an integer (in seconds), e.g., '60' instead of '60s'