Conversation
zanieb
reviewed
Jan 12, 2026
zanieb
approved these changes
Jan 12, 2026
Signed-off-by: William Woodruff <william@astral.sh> Remove unused APIs Signed-off-by: William Woodruff <william@astral.sh> Remove old imports Signed-off-by: William Woodruff <william@astral.sh> remove a line Signed-off-by: William Woodruff <william@astral.sh>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the first of two PRs to enable direct Trusted Publishing to pyx, without an intermediating step (like
pyx-auth-action).This first PR contains no functional changes, just a refactor to make the actual functional changes clearer. Specifically, it adds a
TrustedPublishingServicetrait that describes the behavior of a service that is Trusted Publishing aware, and adds an initialPyPIPublishingServiceimplementation of that trait that matches the current PyPI Trusted Publishing APIs. I'll use the same trait shape to define aPyxPublishingServicein a subsequent PR.(Longer term, once PEP 807 is implemented, we'll also be able to add a
StandardPublishingServiceor whatever and deprecate the other two.)Test Plan
No functional changes. Should be covered by the existing publishing tests.