Add new uv-keyring crate that vendors the keyring-rs crate#14725
Merged
Add new uv-keyring crate that vendors the keyring-rs crate#14725
uv-keyring crate that vendors the keyring-rs crate#14725Conversation
c362c0f to
f824432
Compare
f824432 to
dd52955
Compare
dd52955 to
cd35a4e
Compare
6f13007 to
077a583
Compare
077a583 to
0150bf9
Compare
e023955 to
d1ca7d6
Compare
d1ca7d6 to
8b2dd13
Compare
8b2dd13 to
56ea26a
Compare
43ef62f to
d7e90bc
Compare
6741d9d to
7fb78c7
Compare
7fb78c7 to
326508f
Compare
b14d7df to
bf40b18
Compare
bf40b18 to
b6711c7
Compare
b6711c7 to
ec77be3
Compare
oconnor663
approved these changes
Aug 13, 2025
Contributor
oconnor663
left a comment
There was a problem hiding this comment.
LGTM with a couple comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a first step toward support for storing credentials in the system keyring. The
keyring-rscrate is the best option for system keyring integration, but the latest version (v4) requires either that Linux users havelibdbusinstalled or that it is built withlibdbusvendored in. This is because v4 depends on dbus-secret-service, which was created as an alternative to secret-service so that users are not required to use an async runtime. Since uv does use an async runtime, this is not a good tradeoff for uv.This PR:
keyring-rscrate into a newuv-keyringworkspace cratesecret-servicecrate that does not require clients on Linux to havelibdbuson their machines. This includes updatingCredentialsAPItrait (and implementations) to use async methods.uv-keyringtests tocargo testjobs. Forcargo test | ubuntu, this meant setting up secret service and priming gnome-keyring as an earlier step.keyring-rsPR