Respect global Python version pins in uv tool run and uv tool install
#14112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a8ba14 to
c421cb9
Compare
zanieb
commented
Jun 18, 2025
Comment on lines
393
to
401
| // Allow the existing environment if the user didn't explicitly request another | ||
| // version | ||
| if let Some(ref tool_receipt) = existing_tool_receipt { | ||
| if settings.reinstall.is_all() && tool_receipt.python().is_none() && python_request.is_some() { | ||
| let _ = writeln!( | ||
| printer.stderr(), | ||
| "Ignoring existing environment for `{from}`: the Python interpreter does not match the environment interpreter", | ||
| from = from.name.cyan(), | ||
| ); | ||
| false | ||
| } else { | ||
| true | ||
| } | ||
| } else { | ||
| true | ||
| } |
Member
Author
There was a problem hiding this comment.
I think this could be refactored to avoid the repeated else branches, but the logic should be correct. The comment needs more detail.
Member
Author
|
@jtfmumm want to give this a look and see if we're aligned on the behavior? |
Contributor
The behavior makes sense to me, and is consistent with how I was thinking about it before. |
a9f0a08 to
bc87b21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12921
For
uv tool run, we'll just use the global Python version for all invocations without an explicit alternative request (i.e., via the--pythonflag).For
uv tool install, it's a bit more complicated:--reinstallor--pythonis used--python, we won't use the global Python version, unless the tool is uninstalled firstThe behavior can be demonstrated as follows
This is a little more complicated than always reinstalling when the global Python version pin changes, but I think it's probably more intuitive when actually using the tool. We briefly touched on this when adding global version pins at #12115 (comment)
Minor note: I need to do a self-review of this implementation, as it's a little awkward to encode this behavior in the existing logic.