Support parsing --find-links, --index-url, and --extra-index-url in requirements.txt#1146
Merged
charliermarsh merged 3 commits intomainfrom Jan 29, 2024
Merged
Support parsing --find-links, --index-url, and --extra-index-url in requirements.txt#1146charliermarsh merged 3 commits intomainfrom
--find-links, --index-url, and --extra-index-url in requirements.txt#1146charliermarsh merged 3 commits intomainfrom
Conversation
34934b9 to
8ab2f5d
Compare
04fe9d3 to
8c4c819
Compare
konstin
approved these changes
Jan 29, 2024
c90d880 to
9603348
Compare
d9f54e7 to
d98350c
Compare
d98350c to
8e4809d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for
--find-links,--index-url, and--extra-index-urlarguments when specified in arequirements.txt.It's a mostly-straightforward change. The only uncertain piece is what to do when multiple files include these flags, and/or when we include them on the CLI and in other files.
In general:
--no-index, we respect it.--extra-index-urland--find-linksacross all sources, since those are just vectors.--index-urlin requirements files, we error.--index-urlfrom the command line over any provided in a requirements file.(
pip-compileseems to just pick one semi-arbitrarily when multiple are provided.)Closes #1143.