Skip to content

rename doesn't work for imports from third-party files #1661

@Gankra

Description

@Gankra

Summary

import warnings as abc
from warnings import deprecated as xyz
x = abc
y = xyz

The two instances of abc and xyz are completely unaware of eachother, the lsp just doesn't understand Alias nodes at all. goto-references, find-references, and rename are all broken (weirdly not entirely consistently between vscode and sandbox).

goto-definition/declaration only works by virtue of resolving the aliases (i.e. not pointing at these symbols at all).

Version

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    serverRelated to the LSP server

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions