Resolve latest version instead of downloading latest release #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you for your contribution! Currently on my phone so a dedicated review will follow. Can you already provide more detail on how the new output can be used? |
pollenjp
commented
Nov 29, 2024
pollenjp
commented
Nov 29, 2024
eifinger
requested changes
Nov 29, 2024
Collaborator
eifinger
left a comment
There was a problem hiding this comment.
Really nice addition. I like it alot!
Co-authored-by: Kevin Stillhammer <kevin.stillhammer@gmail.com>
Co-authored-by: Kevin Stillhammer <kevin.stillhammer@gmail.com>
Co-authored-by: Kevin Stillhammer <kevin.stillhammer@gmail.com>
Co-authored-by: Kevin Stillhammer <kevin.stillhammer@gmail.com>
Co-authored-by: Kevin Stillhammer <kevin.stillhammer@gmail.com>
f219245 to
d59153e
Compare
Co-authored-by: Kevin Stillhammer <kevin.stillhammer@gmail.com>
eifinger
approved these changes
Nov 30, 2024
Collaborator
eifinger
left a comment
There was a problem hiding this comment.
Really awesome. Thank you! 🎆
This was referenced Nov 30, 2024
This was referenced Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi, this is my first contribution.
I addressed issue #171 by adjusting the uv
version: latestbehavior. I also addeduv-cache-hitoutput and included CI tests (see attached image).I look forward to your feedback.
Fig.1: success CI
Changes
download-cachedownload-version process.