chore(ci): address all lint findings#206
Merged
eifinger merged 2 commits intoastral-sh:mainfrom Aug 19, 2025
Merged
Conversation
This addresses a variety of findings, mostly around overly broad default permissions and credential sharing. Signed-off-by: William Woodruff <william@astral.sh>
eifinger
reviewed
Aug 15, 2025
Collaborator
eifinger
left a comment
There was a problem hiding this comment.
Thank you for this PR and for introducing me to these tools. Had it on my to-do list for ages to program something like pinact myself 😅 .
Two questions on the changes
Signed-off-by: William Woodruff <william@astral.sh>
eifinger
approved these changes
Aug 19, 2025
Collaborator
eifinger
left a comment
There was a problem hiding this comment.
Awesome changes and explanations, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a variety of findings, mostly around overly broad default permissions and credential sharing.
I've also run pinact to auto-hash-pin all action references -- Dependabot will still update these, but having them hash-pinned will seal off any undesirable tag/branch mutability 🙂
(99% of these findings were done automatically with
zizmor --fix=all, followed by verifying the results. I haven't added a zizmor workflow as part of this PR, but I'd be happy to if desired.)