Add support for reading the ruff version from Poetry groups#127
Add support for reading the ruff version from Poetry groups#127eifinger merged 5 commits intoastral-sh:mainfrom
Conversation
eifinger
left a comment
There was a problem hiding this comment.
Thank you for your contribution. Looks good!
Can you please add a test like
ruff-action/.github/workflows/test.yml
Lines 87 to 103 in 719c6e5
My bad, I messed up my rebase before creating the PR and ended up not including the tests. Compared to the version you saw before I also had to slightly change the approach, since the poetry dependency specification doesn't match the format expected by |
eifinger
left a comment
There was a problem hiding this comment.
It looks like poetry groups are the same as the others, just with one extra layer. We should be able to use the existing approach and keep one function collecting all "dependencies" and the other filtering out the correct ones.
Have I missed stomething?
| fi | ||
| env: | ||
| RUFF_VERSION: ${{ steps.ruff-action.outputs.ruff-version }} | ||
| test-default-version-from-pyproject-poetry-groups: |
There was a problem hiding this comment.
One more thing I forgot. Can you please add this test to the needs section of the all-tests-passed jobs around line 280?
There was a problem hiding this comment.
Good catch! Really should've noticed that one myself 😅
Not sure if this is a desired feature since this was requested already (#40 (comment)) without any sort of response.
Unfortunately Poetry doesn't yet support PEP 735 (python-poetry/poetry#9751) and it doesn't make sense to add ruff as a project dependency.