Allow Boolean positionals in setters#9429
Merged
charliermarsh merged 1 commit intomainfrom Jan 8, 2024
Merged
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| FBT003 | 1 | 0 | 1 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+0 -1 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)
bokeh/bokeh (+0 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --preview --select ALL
- examples/server/app/spectrogram/app_hooks.py:8:17: FBT003 Boolean positional value in function call
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| FBT003 | 1 | 0 | 1 | 0 | 0 |
MichaReiser
reviewed
Jan 8, 2024
Member
MichaReiser
left a comment
There was a problem hiding this comment.
What are the downsides of allowing this calls. Does it increase the rate of false negatives?
MichaReiser
reviewed
Jan 8, 2024
crates/ruff_linter/resources/test/fixtures/flake8_boolean_trap/FBT.py
Outdated
Show resolved
Hide resolved
f0534d7 to
5aec789
Compare
Member
Author
|
@MichaReiser - Yeah, that's right -- there will be some false negatives. But based on the issues, I think this is the right tradeoff -- it's almost always a false positive in these cases, with no workaround. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ignores Boolean trap enforcement for methods that appear to be setters (as in the Qt and pygame APIs).
Closes #9287.
Closes #8923.