Allow # fmt: skip with interspersed same-line comments#9395
Merged
charliermarsh merged 1 commit intomainfrom Jan 5, 2024
Merged
Allow # fmt: skip with interspersed same-line comments#9395charliermarsh merged 1 commit intomainfrom
# fmt: skip with interspersed same-line comments#9395charliermarsh merged 1 commit intomainfrom
Conversation
319df66 to
ebf8a19
Compare
Contributor
|
zanieb
approved these changes
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is similar to #8876, but more limited in scope:
# fmt: skip(like Black). Like# isort: on,# fmt: onneeds to be on its own line (still).#, so you can do# fmt: skip # noqa, but not# fmt: skip - some other contentor# fmt: skip; noqa.If we want to support the
;-delimited version, we should revisit later, since we don't support that in the linter (so# fmt: skip; noqawouldn't register anoqa).Closes #8892.