Add Implementation for Pylint E1132: Repeated Keyword#8706
Add Implementation for Pylint E1132: Repeated Keyword#8706charliermarsh merged 7 commits intoastral-sh:mainfrom
Conversation
|
|
Awesome, thanks for this PR and for getting involved! There's some overlap here with #8450, I'm almost wondering if they should one rule since they both only deal with static dictionary spreads, but I think I need to take a closer look at the code before I have a clear answer to that. |
|
Oh yeah! I totally did not see that other PR. I'm happy to help merge stuff if we go down that route. I also should have mentioned this in the summary, but this is my first meaningful Rust code besides random side projects, so feel free to be extra nit-picky with your comments 😄 |
|
Okay, it's probably fine to just proceed with this rule on its own. Left a few comments! |
|
@charliermarsh Okay this is ready for another pass. All of your comments should be addressed. I also updated some of my destructuring statements to use |
Summary
Adds the Pylint rule E1132 to check for repeated keyword arguments in a function call.
Test Plan
Tested via the included unit tests and manual spot checking.