Skip to content

Refactor and rename skip_trailing_trivia#6312

Merged
charliermarsh merged 2 commits intomainfrom
charlie/deco
Aug 4, 2023
Merged

Refactor and rename skip_trailing_trivia#6312
charliermarsh merged 2 commits intomainfrom
charlie/deco

Conversation

@charliermarsh
Copy link
Member

Based on feedback here: #6274 (comment).

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.01      7.9±0.12ms     5.1 MB/sec    1.00      7.9±0.04ms     5.2 MB/sec
formatter/numpy/ctypeslib.py               1.00  1593.2±24.39µs    10.5 MB/sec    1.00  1593.6±23.21µs    10.4 MB/sec
formatter/numpy/globals.py                 1.01    182.2±1.82µs    16.2 MB/sec    1.00    181.0±3.36µs    16.3 MB/sec
formatter/pydantic/types.py                1.00      3.4±0.03ms     7.6 MB/sec    1.00      3.4±0.06ms     7.5 MB/sec
linter/all-rules/large/dataset.py          1.00     10.7±0.06ms     3.8 MB/sec    1.03     11.0±0.06ms     3.7 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      2.7±0.01ms     6.1 MB/sec    1.01      2.8±0.01ms     6.0 MB/sec
linter/all-rules/numpy/globals.py          1.00    379.2±0.72µs     7.8 MB/sec    1.01    384.2±0.46µs     7.7 MB/sec
linter/all-rules/pydantic/types.py         1.00      4.9±0.02ms     5.2 MB/sec    1.02      5.0±0.04ms     5.1 MB/sec
linter/default-rules/large/dataset.py      1.00      5.2±0.01ms     7.9 MB/sec    1.02      5.3±0.01ms     7.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1115.3±4.09µs    14.9 MB/sec    1.01  1129.5±17.60µs    14.7 MB/sec
linter/default-rules/numpy/globals.py      1.00    125.3±1.50µs    23.6 MB/sec    1.01    127.0±3.41µs    23.2 MB/sec
linter/default-rules/pydantic/types.py     1.00      2.3±0.01ms    10.9 MB/sec    1.02      2.4±0.04ms    10.7 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      7.5±0.03ms     5.4 MB/sec    1.01      7.6±0.04ms     5.4 MB/sec
formatter/numpy/ctypeslib.py               1.00  1464.4±13.20µs    11.4 MB/sec    1.02   1488.4±7.60µs    11.2 MB/sec
formatter/numpy/globals.py                 1.00    152.1±1.74µs    19.4 MB/sec    1.01    154.4±3.15µs    19.1 MB/sec
formatter/pydantic/types.py                1.00      3.2±0.03ms     8.0 MB/sec    1.01      3.3±0.03ms     7.8 MB/sec
linter/all-rules/large/dataset.py          1.01     10.7±0.04ms     3.8 MB/sec    1.00     10.6±0.05ms     3.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      2.7±0.01ms     6.1 MB/sec    1.00      2.7±0.01ms     6.1 MB/sec
linter/all-rules/numpy/globals.py          1.00    295.1±3.69µs    10.0 MB/sec    1.00    294.3±2.50µs    10.0 MB/sec
linter/all-rules/pydantic/types.py         1.01      4.8±0.02ms     5.3 MB/sec    1.00      4.8±0.02ms     5.3 MB/sec
linter/default-rules/large/dataset.py      1.01      5.5±0.03ms     7.4 MB/sec    1.00      5.4±0.04ms     7.5 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01  1087.5±11.52µs    15.3 MB/sec    1.00   1073.6±6.34µs    15.5 MB/sec
linter/default-rules/numpy/globals.py      1.00    112.0±0.82µs    26.3 MB/sec    1.00    112.0±0.82µs    26.3 MB/sec
linter/default-rules/pydantic/types.py     1.01      2.4±0.02ms    10.7 MB/sec    1.00      2.4±0.01ms    10.8 MB/sec

@charliermarsh charliermarsh added the formatter Related to the formatter label Aug 3, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) August 4, 2023 13:21
@charliermarsh charliermarsh merged commit 1e3fe67 into main Aug 4, 2023
@charliermarsh charliermarsh deleted the charlie/deco branch August 4, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

formatter Related to the formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants