Conversation
Format statements such as `tree_depth += 1`. This is a statement that does not allow any line breaks, the only thing to be mindful of is to parenthesize the assigned expression
Contributor
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
MichaReiser
approved these changes
Jul 11, 2023
Member
MichaReiser
left a comment
There was a problem hiding this comment.
Nice!
Please update #4798 or create an issue an link it to the PR so that we keep track of the (at least partially) implemented syntax.
| write!( | ||
| f, | ||
| [ | ||
| target.format(), |
Member
There was a problem hiding this comment.
Stmt formatting can be so nice. Expressions are the real pain
72 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Format statements such as
tree_depth += 1. This is a statement that does not allow any line breaks, the only thing to be mindful of is to parenthesize the assigned expressionJaccard index on django: 0.915 -> 0.918
Test Plan
black tests, and two new tests, a basic one and one that ensures that the child gets parentheses. I ran the django stability check.