Skip to content

Add Applicability to flake8_logging_format fixes#5129

Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom
evanrittenhouse:applicability_logging
Jun 15, 2023
Merged

Add Applicability to flake8_logging_format fixes#5129
charliermarsh merged 1 commit intoastral-sh:mainfrom
evanrittenhouse:applicability_logging

Conversation

@evanrittenhouse
Copy link
Contributor

@evanrittenhouse evanrittenhouse commented Jun 15, 2023 •
edited
Loading

Summary

Fixes some of #4184

Test Plan

@evanrittenhouse evanrittenhouse force-pushed the applicability_logging branch from fa9825e to 61e0efc Compare June 15, 2023 19:43
@evanrittenhouse evanrittenhouse force-pushed the applicability_logging branch from 61e0efc to 3e19d22 Compare June 15, 2023 19:48
This was referenced Jun 15, 2023
Closed
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023 •
edited
Loading

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      6.8±0.02ms     5.9 MB/sec    1.00      6.8±0.01ms     6.0 MB/sec
formatter/numpy/ctypeslib.py               1.00   1393.3±2.50µs    12.0 MB/sec    1.00   1395.5±3.03µs    11.9 MB/sec
formatter/numpy/globals.py                 1.01    138.3±0.58µs    21.3 MB/sec    1.00    136.7±0.28µs    21.6 MB/sec
formatter/pydantic/types.py                1.01      2.8±0.01ms     9.1 MB/sec    1.00      2.8±0.01ms     9.2 MB/sec
linter/all-rules/large/dataset.py          1.00     14.3±0.04ms     2.9 MB/sec    1.02     14.5±0.06ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.5±0.01ms     4.7 MB/sec    1.00      3.5±0.02ms     4.7 MB/sec
linter/all-rules/numpy/globals.py          1.00    370.7±0.84µs     8.0 MB/sec    1.00    370.4±2.37µs     8.0 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.2±0.03ms     4.1 MB/sec    1.00      6.2±0.02ms     4.1 MB/sec
linter/default-rules/large/dataset.py      1.00      7.2±0.02ms     5.7 MB/sec    1.01      7.2±0.03ms     5.6 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1507.3±3.54µs    11.0 MB/sec    1.01   1521.2±2.44µs    10.9 MB/sec
linter/default-rules/numpy/globals.py      1.01    166.0±3.23µs    17.8 MB/sec    1.00    164.6±0.21µs    17.9 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.3±0.01ms     7.7 MB/sec    1.00      3.3±0.01ms     7.7 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.04     10.2±0.44ms     4.0 MB/sec    1.00      9.8±0.52ms     4.2 MB/sec
formatter/numpy/ctypeslib.py               1.05  1992.2±97.85µs     8.4 MB/sec    1.00  1891.8±79.82µs     8.8 MB/sec
formatter/numpy/globals.py                 1.00    197.4±9.00µs    14.9 MB/sec    1.05   207.7±26.26µs    14.2 MB/sec
formatter/pydantic/types.py                1.04      4.0±0.16ms     6.3 MB/sec    1.00      3.9±0.16ms     6.6 MB/sec
linter/all-rules/large/dataset.py          1.00     20.6±0.78ms  2024.3 KB/sec    1.01     20.8±1.13ms  2000.2 KB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      5.2±0.24ms     3.2 MB/sec    1.02      5.3±0.22ms     3.1 MB/sec
linter/all-rules/numpy/globals.py          1.00   619.3±27.14µs     4.8 MB/sec    1.04   642.9±31.64µs     4.6 MB/sec
linter/all-rules/pydantic/types.py         1.03      9.2±0.38ms     2.8 MB/sec    1.00      8.9±0.38ms     2.9 MB/sec
linter/default-rules/large/dataset.py      1.00     10.6±0.63ms     3.8 MB/sec    1.01     10.7±0.64ms     3.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.02      2.2±0.16ms     7.5 MB/sec    1.00      2.2±0.11ms     7.7 MB/sec
linter/default-rules/numpy/globals.py      1.01   264.8±13.93µs    11.1 MB/sec    1.00   262.0±13.18µs    11.3 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.7±0.37ms     5.5 MB/sec    1.00      4.7±0.19ms     5.5 MB/sec

zanieb
zanieb approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling these :)

@charliermarsh charliermarsh merged commit 89b328c into astral-sh:main Jun 15, 2023
@evanrittenhouse evanrittenhouse deleted the applicability_logging branch June 15, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanieb zanieb zanieb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evanrittenhouse @zanieb @charliermarsh