Skip to content

Misc. follow-up changes to #3802#3803

Merged
charliermarsh merged 1 commit intomainfrom
charlie/follow-up
Mar 29, 2023
Merged

Misc. follow-up changes to #3802#3803
charliermarsh merged 1 commit intomainfrom
charlie/follow-up

Conversation

@charliermarsh
Copy link
Member

Forgot to push these prior to auto-merging.

@charliermarsh charliermarsh merged commit 8829875 into main Mar 29, 2023
@charliermarsh charliermarsh deleted the charlie/follow-up branch March 29, 2023 23:18
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     14.5±0.02ms     2.8 MB/sec    1.00     14.4±0.03ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.7±0.01ms     4.5 MB/sec    1.00      3.7±0.01ms     4.5 MB/sec
linter/all-rules/numpy/globals.py          1.00    410.6±2.37µs     7.2 MB/sec    1.00    410.7±0.97µs     7.2 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.3±0.01ms     4.1 MB/sec    1.00      6.3±0.01ms     4.1 MB/sec
linter/default-rules/large/dataset.py      1.00      7.7±0.01ms     5.3 MB/sec    1.00      7.7±0.12ms     5.3 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01   1712.1±3.25µs     9.7 MB/sec    1.00  1702.0±15.36µs     9.8 MB/sec
linter/default-rules/numpy/globals.py      1.00    178.7±0.43µs    16.5 MB/sec    1.01    180.4±0.64µs    16.4 MB/sec
linter/default-rules/pydantic/types.py     1.01      3.6±0.01ms     7.1 MB/sec    1.00      3.6±0.02ms     7.2 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     15.7±0.18ms     2.6 MB/sec    1.00     15.8±0.21ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.1±0.06ms     4.0 MB/sec    1.00      4.1±0.06ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.00    501.8±8.02µs     5.9 MB/sec    1.00   499.6±10.18µs     5.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.8±0.10ms     3.8 MB/sec    1.00      6.8±0.10ms     3.8 MB/sec
linter/default-rules/large/dataset.py      1.00      8.2±0.06ms     5.0 MB/sec    1.01      8.2±0.09ms     4.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1799.9±27.76µs     9.3 MB/sec    1.00  1807.7±47.79µs     9.2 MB/sec
linter/default-rules/numpy/globals.py      1.00    192.8±3.16µs    15.3 MB/sec    1.02    196.8±6.64µs    15.0 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.8±0.05ms     6.8 MB/sec    1.00      3.8±0.05ms     6.8 MB/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant