Match 5-character rule codes in ecosystem check#25677
Merged
Merged
Conversation
Summary -- I noticed while extending the regex to match human-readable names that it also didn't cover the ASYNC rules, which have five letters in the rule code. For example, #24644 revealed no new diagnostics in the ecosystem, but a local run on my cached ecosystem repos revealed many diagnostics. This won't show up as a diff in CI on this PR but should help with ecosystem checks on the ASYNC rules in the future.
|
MichaReiser
approved these changes
Jun 8, 2026
| # the old and new rendering with severities. | ||
| CHECK_DIAGNOSTIC_LINE_RE = re.compile( | ||
| r"^(?P<diff>[+-])? ?(?P<location>.*): (?:(?P<severity>[a-z]+)\[)?(?P<code>[A-Z]{1,4}[0-9]{3,4}|[a-z\-]+:)\]?(?P<fixable> \[\*\])? (?P<message>.*)" | ||
| r"^(?P<diff>[+-])? ?(?P<location>.*): (?:(?P<severity>[a-z]+)\[)?(?P<code>[A-Z]{1,5}[0-9]{3,4}|[a-z\-]+:)\]?(?P<fixable> \[\*\])? (?P<message>.*)" |
Member
There was a problem hiding this comment.
Not something we have to do now but can we come up with a regex that will also work with human readable names and doesn't require length constraints (which seems very error prone)
Contributor
Author
There was a problem hiding this comment.
Yeah that's what I was working on when I found this. On Amy's PR I tried normalizing them so that we avoided seeing any changes in the ecosystem report. I'm not sure if we want to go that far, but it also has a working regex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed while extending the regex to match human-readable names that it also didn't cover the
ASYNC rules, which have five letters in the rule code. For example, #24644 revealed no new
diagnostics in the ecosystem, but a local run on my cached ecosystem repos revealed many
diagnostics. This won't show up as a diff in CI on this PR but should help with ecosystem checks on
the ASYNC rules in the future.