[ty] Fix anchor point for override diagnostics#25621
Merged
Merged
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 92.13%. The percentage of expected errors that received a diagnostic held steady at 87.18%. The number of fully passing files held steady at 92/134. |
Memory usage reportMemory usage unchanged ✅ |
|
762f5e0 to
d1b0bc2
Compare
missing-override-decorator diagnostics for inherited property accessors.e85d9f0 to
e47cde1
Compare
e47cde1 to
9f6e8d0
Compare
MichaReiser
reviewed
Jun 4, 2026
charliermarsh
approved these changes
Jun 4, 2026
Diagnostics for `invalid-explicit-override` and `missing-override-decorator` should both be anchored to a definition in the file currently being checked (which is where the override occurs). Previously, we handled this incorrectly for property instances by assuming that the getter was always the accessor to use as the diagnostic target (even if we were actually overriding a different accessor, such as the setter). Now, we correctly consider all property accessors and choose the override in the file being checked as the diagnostic target.
9f6e8d0 to
94885f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This corrects the range to which we anchor diagnostics for
invalid-explicit-overrideandmissing-override-decoratorerrors. Both are now anchored to a definition in the file currently being checked (which is where the override occurs).Previously, we handled this incorrectly for property instances in particular by assuming that the getter was always the accessor to use as the diagnostic target (even if we were actually overriding a different accessor, such as the setter). Now, we correctly consider all property accessors and choose the override in the file being checked as the diagnostic target.
Closes astral-sh/ty#3654.
Test Plan
Please see included tests.